Advanced WOL

seconds passed

Thank you for porting Advanced Wake on LAN to kodi matrix. I use english and noticed it says seconds left instead of seconds passed in both the german and english strings.po.

Google translate:

Sekunden vergingen

Vielen Dank, dass Sie Advanced Wake on LAN auf die Kodi-Matrix portiert haben. Ich benutze Englisch und bemerkte, dass sowohl in der deutschen als auch in der englischen string.po Sekunden übrig statt Sekunden vergangen sind.

--- strings.po.original 2023-02-21 20:26:27.000000000 -0500
+++ strings.po  2023-02-22 08:43:27.047653108 -0500
@@ -146,7 +146,7 @@
 msgstr "Warte auf Verfügbarkeit von %s..."


 msgctxt "#60002"
-msgid "%s of %s seconds left"
+msgid "%s of %s seconds passed"
 msgstr "%s von %s Sekunden vergangen"


 msgctxt "#60003"

--- strings.po.original 2023-02-21 20:26:27.000000000 -0500
+++ strings.po  2023-02-22 08:40:40.948801156 -0500
@@ -146,7 +146,7 @@
 msgstr ""


 msgctxt "#60002"
-msgid "%s of %s seconds left"
+msgid "%s of %s seconds passed"
 msgstr ""


 msgctxt "#60003"

Updated and the progress message is fixed. Danke schön!

Another GUI improvement for this addon.

--- default.py.original 2023-02-22 14:36:59.000000000 -0500
+++ default.py  2023-03-11 22:21:12.373353067 -0500
@@ -137,9 +137,9 @@
         while now - timecount <= pingTimeout:
             success = ping.ping_ip(hostOrIp)
             if not success:
+                now = int(time.time())
                 dbg.bg_progress((now - timecount) * 100 // pingTimeout,
                                 language(60002) % (now - timecount, pingTimeout))
-                now = int(time.time())
             else:
                 xbmc.[definition='1','0']log[/definition]('last ping was successful, {} secs needed'.format(now - timecount), xbmc.LOGDEBUG)
                 if delayHostupNotifies > 0:

Why? Update the now variable before displaying the progress message instead of after, otherwise we are always showing 5 seconds below the actual elapsed time because the ping subprocess timeout is a non-negligible 5 seconds.

subprocess.run("ping -{} 1 {}".format(count, current_ip_address), shell=
True, check=True, timeout=5)

The old addon on linux used to ping every second and I got used to how many seconds my server takes to wake up and noticed the number is now much lower. Here's a change that makes it refresh every second as before:

--- default.py.original 2023-02-22 14:36:59.000000000 -0500
+++ default.py  2023-03-12 09:50:11.716656426 -0400
@@ -135,11 +135,11 @@
         dbg = DialogBG(language(60001) % hostOrIp,
                        language(60002) % (now - timecount, pingTimeout), enablePingCounterNotifies)
         while now - timecount <= pingTimeout:
-            success = ping.ping_ip(hostOrIp)
+            success = ping.ping_ip(hostOrIp, 1)
+            now = int(time.time())
             if not success:
                 dbg.bg_progress((now - timecount) * 100 // pingTimeout,
                                 language(60002) % (now - timecount, pingTimeout))
-                now = int(time.time())
             else:
                 xbmc.[definition='1','0']log[/definition]('last ping was successful, {} secs needed'.format(now - timecount), xbmc.LOGDEBUG)
                 if delayHostupNotifies > 0:

--- resources/lib/ping.py.original      2023-02-22 14:36:59.000000000 -0500
+++ resources/lib/ping.py       2023-03-12 10:00:08.065004844 -0400
@@ -7,8 +7,9 @@


 def ping_ip(current_ip_address, timeout=1):
     count = 'n' if platform.system().lower() == 'windows' else 'c'
+    wait = '-w 1000' if platform.system().lower() == 'windows' else ''
     try:
-        subprocess.run("ping -{} 1 {}".format(count, current_ip_address), shell=True, check=True, timeout=5)
+        subprocess.run("ping -{} 1 {} {}".format(count, wait, current_ip_address), shell=True, check=True, timeout=timeout)
         return True
     except (subprocess.CalledProcessError, subprocess.TimeoutExpired) as e:
         print('Ping returns an error: {}'.format(e))

The now variable is refreshed right after the ping so the now in the [definition='1','0']log[/definition] file is correct too.
Warning: I don't really know python and I only tested on linux so Windows is untested but it should hopefully work!

Good then it should work on windows too. I'm really happy with the behavior on linux with this small tweak making it like the original. The ", 1" I added in the ping_ip call is useless since the default timeout is 1 already.

My kodi linux just updated to the new 3.09 Advanced WOL and it works great. Danke schön!

I tried this addon on Windows 10 and it didn't work. It turns out the addon is fine and kodi is fine. The problem is if you have VirtualBox installed on windows (not even currently running it) the magic packet gets sent to the wrong network interface. Workaround here.

Hope this helps someone.

I'm on Kodi 20.3 Nexus on Windows

The "Advanced WOL addon" which was working perfectly, updated today.

I noticed an extra NG at the end of the name "Advanced WOL NG" (No Good ? )

It ran infinitely without waking anything up.

Went into the settings and device name and MAC address were lost. I set them.

Now it wakes up the host but showed 1 of 32000 seconds passed.

Changed "ping timeout for host up check" to 30. It displays 30 instead of 32xxx

If the host is already awake it says so but the spinning wheel is displayed for 1-2s uselessly (old version didn't do that).

When I exit kodi it freezes/hangs. If in fullscreen mode I have to logout as my task manager is not set to always on top. If the "Advanced WOL NG" addon was not run, kodi exits normally.

While installing I saw a new icon like in the repo with a big 4 on it. The icon has reverted to the old one without the 4 both in the Add-ons and Favourites screens.

Upgraded to 4.0.1 and the freeze on exit on Windows seems to be fixed (minimal testing).

Can't speak to the 32xxx bug as that had already disappeared from 4.0.0 after changing the settings.

Deleted the old thumbnail manually from the cache. The installer could do this?

Back in business. Thanks for the quick fix.